| Summary: | Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, jonlee, mjs, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2014-09-28 11:54:01 PDT
Created attachment 238819 [details]
Patch
Created attachment 238824 [details]
Patch
Comment on attachment 238824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review > Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30 > +#else This should not be an else, we should forward declare functions unconditionally. Also, I think the the file name should end with SPI by convention. Comment on attachment 238824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review >> Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30 >> +#else > > This should not be an else, we should forward declare functions unconditionally. > > Also, I think the the file name should end with SPI by convention. Done. Done. |