Bug 137184 – Use the new is<>() / downcast<>() for more Node subclasses

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

Use the new is<>() / downcast<>() for more Node subclasses

[Chris Dumez]

Created attachment 238792 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 238792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238792&action=review

> Source/WebCore/dom/Range.cpp:665
>      case Node::PROCESSING_INSTRUCTION_NODE:
> -        return toProcessingInstruction(node)->data().length();
> +        return downcast<ProcessingInstruction>(*node).data().length();

Since ProcessingInstruction inherits from CharacterData, can't we combine this with the case above??

> Source/WebCore/dom/Range.cpp:1163
>          case Node::PROCESSING_INSTRUCTION_NODE:
> -            if (static_cast<unsigned>(offset) > toProcessingInstruction(n)->data().length())
> +            if (static_cast<unsigned>(offset) > downcast<ProcessingInstruction>(*n).data().length())

Ditto about merging this case with CharacterData.

[Chris Dumez]

Comment on attachment 238792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238792&action=review

>> Source/WebCore/dom/Range.cpp:665
>> +        return downcast<ProcessingInstruction>(*node).data().length();
> 
> Since ProcessingInstruction inherits from CharacterData, can't we combine this with the case above??

Nice catch, I don't see why not.

[Chris Dumez]

Created attachment 238797 [details]
Patch

[Chris Dumez]

Created attachment 238801 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 238801 [details]
Patch

Clearing flags on attachment: 238801

Committed r174039: <http://trac.webkit.org/changeset/174039>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.