Summary: | REGRESSION (r172532): JSBase.h declares NSMapTable functions that are SPI | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||||
Component: | JavaScriptCore | Assignee: | Daniel Bates <dbates> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, benjamin, cmarcelo, commit-queue, dbates, ggaren, mjs, msaboff, oliver | ||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
mitz
2014-09-26 21:14:17 PDT
Can those declarations be in the prefix header instead? (In reply to comment #1) > Can those declarations be in the prefix header instead? I could move those declarations to the prefix header. I plan to move the forward declarations for XPC SPI that we use in JavaScriptCore (*) to a file in WTF/wtf/spi (so that they can be shared with projects JavaScriptCore, WebCore, and WebKit). As we discussed in-person today (09/30), I propose moving these declarations to WTF/wtf/spi/NSMapTableSPI.h for consistency. This would also make it straight forward to use NSMapTable SPI in other projects in the future (by including WTF/wtf/spi/NSMapTableSPI.h). (*) For instance, <http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/inspector/remote/RemoteInspector.mm?rev=174028#L41> Created attachment 238933 [details]
Patch
Created attachment 238935 [details]
Patch
Created attachment 238936 [details] Patch Rebased patch following <http://trac.webkit.org/changeset/174108> (bug #137254) Created attachment 238938 [details]
Patch
Add radar bug URL to change log entry. Also remove inline comment "__OBJC__" from file Source/JavaScriptCore/API/JSBase.h as it is obvious that the macro #endif directive corresponds to the #ifdef __OBJC__ directive.
Comment on attachment 238938 [details]
Patch
r=me
Committed r174110: <http://trac.webkit.org/changeset/174110> |