| Summary: | Web Inspector: Type Token View shows type information on hover when it shouldn't | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | Web Inspector | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
(In reply to comment #0) > TypeTokenView::_shouldShowPopover is broken: > > One of its conditions reads: > if (this._types.structures && this._types.structures) { ... } > > But it should be written as: > if (this._types.structures && this._types.structures.length > 1) { ... } This should actually be: if (this._types.structures && this._types.structures.length >= 1) { ... } because we care if there is only one object or more, not more than one. Created attachment 238737 [details]
patch
Comment on attachment 238737 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=238737&action=review > Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:135 > + if (this._types.structures && this._types.structures.length >= 1) I think you can drop the >= 1 here. landed in: http://trac.webkit.org/changeset/174019 |
TypeTokenView::_shouldShowPopover is broken: One of its conditions reads: if (this._types.structures && this._types.structures) { ... } But it should be written as: if (this._types.structures && this._types.structures.length > 1) { ... }