| Summary: | Fix typo in YARR at BOL check | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Binderman <dcb314> | ||||
| Component: | JavaScriptCore | Assignee: | Peter Varga <pvarga> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, msaboff, ossy, pvarga | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
The code is still in trunk, cc-ing YARR experts. Created attachment 238708 [details]
proposed patch
Comment on attachment 238708 [details]
proposed patch
OK to make this change, but it was OK to use & here since both values were booleans and the second expression had no side effect.
Comment on attachment 238708 [details] proposed patch Clearing flags on attachment: 238708 Committed r174012: <http://trac.webkit.org/changeset/174012> All reviewed patches have been landed. Closing bug. |
webkitgtk-2.5.90/Source/JavaScriptCore/yarr/YarrPattern.cpp:300]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses. Source code is if (!m_alternative->m_terms.size() & !m_invertParentheticalAssertion) { Maybe if (!m_alternative->m_terms.size() && !m_invertParentheticalAssertion) { was intended.