| Summary: | [freetype] Fix support for the initial-letter CSS property to first-letter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lorenzo Tilve <ltilve> | ||||
| Component: | CSS | Assignee: | Lorenzo Tilve <ltilve> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, mmaxfield, mrobinson, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Lorenzo Tilve
2014-09-25 00:43:44 PDT
Created attachment 238646 [details]
Patch
Is freetype only used by GTK+ port? (In reply to comment #2) > Is freetype only used by GTK+ port? (In reply to comment #2) > Is freetype only used by GTK+ port? It is being also used on EFL, so renaming the bug from [GTK] to [freetype]. Thanks for the remark. Comment on attachment 238646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238646&action=review > LayoutTests/ChangeLog:15 > + * platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added. > + * platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added. > + * platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added. > + * platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added. > + * platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added. > + * platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added. This is confusing. Are these tests currently skipped, which is why they didn't have -expected.txt's? Is it possible to use reftests instead so that they can be platform non-specific? (In reply to comment #5) > > LayoutTests/ChangeLog:15 > > + * platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added. > > + * platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added. > > + * platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added. > > + * platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added. > > + * platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added. > > + * platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added. > > This is confusing. Are these tests currently skipped, which is why they didn't have -expected.txt's? Those -expected.txt's were missing (they were not skipped on any TestExpectations either): https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/2994/steps/layout-test/logs/stdio Regressions: Unexpected missing results (6) fast/css-generated-content/initial-letter-basic.html [ Missing ] fast/css-generated-content/initial-letter-border-padding.html [ Missing ] fast/css-generated-content/initial-letter-clearance.html [ Missing ] fast/css-generated-content/initial-letter-descender.html [ Missing ] fast/css-generated-content/initial-letter-raised.html [ Missing ] fast/css-generated-content/initial-letter-sunken.html [ Missing ] When the tests were introduced at r173217 <http://trac.webkit.org/changeset/173217>, only the mac expectations were added, so that's why I'm adding those missing ones now that it would be also supported in GTK+ too. unofficial r=me Comment on attachment 238646 [details] Patch Clearing flags on attachment: 238646 Committed r174002: <http://trac.webkit.org/changeset/174002> All reviewed patches have been landed. Closing bug. |