Bug 137082 – Web Replay: record event loop timings using elapsed time during capturing only

• Component: Web Inspector
• Status: RESOLVED LATER

[Brian Burg]

We capture new timings on capture/replay currently, which makes it hard to do anything sensible on the timelines UI.

[Radar WebKit Bug Importer]

<rdar://problem/18447710>

[Brian Burg]

Created attachment 238616 [details]
WIP

[Timothy Hatcher]

Comment on attachment 238616 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=238616&action=review

> Source/WebCore/replay/CapturingInputCursor.cpp:62
> +    , m_stopwatch(Stopwatch::create())

Maybe I don't understand. but it seems odd to create and store Stopwatch here.

> Source/WebCore/replay/ReplaySessionSegment.h:56
> +    Vector<double, 0>& eventLoopTimings() { return m_eventLoopTimings; }

Why the ", 0"? Isn't that the default?

[Brian Burg]

(In reply to comment #3)
> Comment on attachment 238616 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=238616&action=review
> 
> > Source/WebCore/replay/CapturingInputCursor.cpp:62
> > +    , m_stopwatch(Stopwatch::create())
> 
> Maybe I don't understand. but it seems odd to create and store Stopwatch
> here.

It seemed like the best place for the stopwatch. CapturingInputCursor is only available while capturing, and we only need this stopwatch during capturing. If it belonged to ReplayController it might be shared accidentally between sessions. It could belong on ReplaySession or ReplaySessionSegment, but then it would do nothing but waste space once capturing is done.

[Brian Burg]

Created attachment 244613 [details]
WIP

[Brian Burg]

Comment on attachment 244613 [details]
WIP

Wrong bug. webkit-patch gets real confused by git sometimes :(

[Blaze Burg]

Closing web replay-related bugs until we resume working on the feature again.