Summary: | Unprefix CSS cursor values zoom-in and zoom-out | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sungmann Cho <sungmann.cho> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Sungmann Cho
2014-09-24 00:54:57 PDT
Created attachment 238589 [details]
Patch
Attachment 238589 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:435: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:436: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 238638 [details]
Patch
Comment on attachment 238638 [details]
Patch
Looks good to me.
Cleaning up the enum is a nice touch :)
Comment on attachment 238638 [details] Patch Clearing flags on attachment: 238638 Committed r173989: <http://trac.webkit.org/changeset/173989> All reviewed patches have been landed. Closing bug. |