Bug 137061

Summary: Unprefix CSS cursor values zoom-in and zoom-out
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Sungmann Cho
Reported 2014-09-24 00:54:57 PDT
-webkit-zoom-in and -webkit-zoom-out are kept as aliases.
Attachments
Patch (10.77 KB, patch)
2014-09-24 01:13 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (21.72 KB, patch)
2014-09-24 20:52 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2014-09-24 01:13:14 PDT
Created attachment 238589 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-24 01:15:02 PDT
Attachment 238589 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:435: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:436: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sungmann Cho
Comment 3 2014-09-24 20:52:43 PDT
Created attachment 238638 [details] Patch
Benjamin Poulain
Comment 4 2014-09-25 17:38:24 PDT
Comment on attachment 238638 [details] Patch Looks good to me. Cleaning up the enum is a nice touch :)
WebKit Commit Bot
Comment 5 2014-09-25 18:01:00 PDT
Comment on attachment 238638 [details] Patch Clearing flags on attachment: 238638 Committed r173989: <http://trac.webkit.org/changeset/173989>
WebKit Commit Bot
Comment 6 2014-09-25 18:01:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.