Summary: | REGRESSION (r21026): deviantART chat broken by change between r21003 and r21059 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Elliott Sprehn <esprehn> |
Component: | Evangelism | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | darin, jensimmons, webkit |
Priority: | P2 | Keywords: | HasReduction, InRadar, Regression |
Version: | 523.x (Safari 3) | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://chat.deviantart.com/chat/devart | ||
Attachments: |
Description
Elliott Sprehn
2007-05-13 00:54:29 PDT
Created attachment 14531 [details] HTML Sample HTML from a chat page that illustrates the change that happened. Viewing it in the two different nightlies shows the problem. Also note Firefox renders the page like r21003. The chat page renders correctly in the Safari 3 Beta, however it's still broken in the latest nightly (r24096). What revision is in Safari 3 and what is different? I can confirm that a part of the "send" button is visible in Firefox and in r18068 (and also in WinIE 7), but the button is fully obscured in shipping WebKit and in r23922. However, all the renderings look pretty wrong - is this the case on the actual server, too? Created attachment 15448 [details]
Safari 3 Rendering (Actual Server)
This is how the page looks when viewing the page sent by the actual server (chat.deviantart.com).
Created attachment 15449 [details]
Firefox 2 Rendering (Actual Server)
How the page renders in Firefox 2 when sent from the actual server (chat.deviantart.com).
Created attachment 15450 [details] Webkit (r24096) Rendering (Actual Server) How the page renders in the webkit nightly. Created attachment 15451 [details] Webkit (r24096) Rendering (Actual Server) How the page renders in the webkit nightly. Created attachment 15452 [details]
Safari 3 Rendering (Attached HTML Sample)
How the test case renders.
Created attachment 15453 [details]
Firefox 2 Rendering (Attached HTML Sample)
How Firefox 2 renders the sample.
Created attachment 15454 [details] Webkit (r24096) Rendering (Attached HTML Sample) How the nightly renders the page. (In reply to comment #3) > I can confirm that a part of the "send" button is visible in Firefox and in > r18068 (and also in WinIE 7), but the button is fully obscured in shipping > WebKit and in r23922. > > However, all the renderings look pretty wrong - is this the case on the actual > server, too? > I've attached renderings from Firefox 2, Safari 3 and Webkit nightlies. Firefox 2 and Safari 3 render the page correctly while the nightly does not. Safari 2 renders the page like the nightly. This is true of the test case and the actual page sent by the server. With the test case the send button should be partially obscured (as seen in FF2 and Safari 3), however it is not on the actual page. I think this might relate to some JS that runs on the page? Looking at the nightly and the area where messages appear in the center (light grey), it is much too wide and also too tall. The bottom of it is obscured under the input box at the bottom so you need to receive several messages in the channel before the first message becomes visible. The side of the box also ends up under the user list and out the side causing a long horizontal scroll bar. Changing every instance of 'box-sizing' to '-webkit-box-sizing' in the sample HTML and related CSS results in layout that looks very similar to the Firefox 2 layout. WebKit's 'box-sizing' was renamed to '-webkit-box-sizing' in <http://trac.webkit.org/projects/webkit/changeset/21026> in order to fix E*TRADE. (In reply to comment #12) > Changing every instance of 'box-sizing' to '-webkit-box-sizing' in the sample > HTML and related CSS results in layout that looks very similar to the Firefox 2 > layout. WebKit's 'box-sizing' was renamed to '-webkit-box-sizing' in > <http://trac.webkit.org/projects/webkit/changeset/21026> in order to fix > E*TRADE. > How does this explain the difference between Safari 3 Beta and the Webkit nightly? Both seem to render E*TRADE fine. Was it only renamed in the nightly, and not Safari 3? There must be something else different between the two of them. (In reply to comment #13) > Both seem to render E*TRADE fine. E*TRADE may have changed in the mean time. > Was it only renamed in the nightly, > and not Safari 3? Yes. In the Safari 3 beta it is still 'box-sizing'. This should be fixed in the WebKit nightly builds. Please re-open if it is not. <rdar://problem/5335881> Dave, I had just created the radar for this :p This is still broken because box-sizing is called -webkit-box-sizing in the nightlies. Is there a reason the nightlies have -webkit-box-sizing while the Safari 3 build has box-sizing? (In reply to comment #17) > This is still broken because box-sizing is called -webkit-box-sizing in the > nightlies. > > Is there a reason the nightlies have -webkit-box-sizing while the Safari 3 > build has box-sizing? It was changed to fix etrade.com per Comment #12. It was changed to be -webkit-box-sizing (as I understand it) because box-sizing is a CSS3 property whose definition may still change. http://www.css3.info/preview/box-sizing.html The chat.devinart.com site should be using -webkit-box-sizing for now to be compatible with Safari. Should this be an evangelism bug? (In reply to comment #18) > (In reply to comment #17) > > This is still broken because box-sizing is called -webkit-box-sizing in the > > nightlies. > > > > Is there a reason the nightlies have -webkit-box-sizing while the Safari 3 > > build has box-sizing? > > It was changed to fix etrade.com per Comment #12. It was changed to be > -webkit-box-sizing (as I understand it) because box-sizing is a CSS3 property > whose definition may still change. > > http://www.css3.info/preview/box-sizing.html > > The chat.devinart.com site should be using -webkit-box-sizing for now to be > compatible with Safari. Should this be an evangelism bug? > If it's going to be changed to -webkit-box-sizing in future versions of Safari 3, then yeah, this looks like an evangelism bug. Evangelism bug shouldn't have P1 priority. |