| Summary: | Implement WKPageIsPlayingAudio() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||||
| Component: | WebKit2 | Assignee: | Ada Chan <adachan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, eric.carlson, jer.noble, pnormand | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 137218 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ada Chan
2014-09-23 16:23:42 PDT
Created attachment 239386 [details]
Patch: Implemented WKPageIsPlayingAudio() and the TestWebKitAPI test for it.
Created attachment 239416 [details]
Updated patch
Maybe I shouldn't have passed in --binary when creating the patch? Attached updated patch generated without --binary.
Created attachment 239421 [details]
Updated patch: this time using git diff.
Comment on attachment 239421 [details] Updated patch: this time using git diff. View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review > Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77 > + WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate()); Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually. (In reply to comment #4) > (From update of attachment 239421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77 > > + WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate()); > > Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually. I've changed the code to use adoptWK(). Thanks for reviewing! Committed: http://trac.webkit.org/changeset/174463 |