Bug 137039

Summary: Have DataTransfer::files() return a reference
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-09-23 12:53:19 PDT
Have DataTransfer::files() return a reference instead of a pointer as it can never return null.
Attachments
Patch (2.53 KB, patch)
2014-09-23 12:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.55 KB, patch)
2014-09-23 13:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-23 12:54:54 PDT
Created attachment 238560 [details] Patch
Ryosuke Niwa
Comment 2 2014-09-23 13:43:03 PDT
Comment on attachment 238560 [details] Patch r=me provided you fix Windows.
Chris Dumez
Comment 3 2014-09-23 13:47:46 PDT
(In reply to comment #2) > (From update of attachment 238560 [details]) > r=me provided you fix Windows. It doesn't seem related to my patch?
Chris Dumez
Comment 4 2014-09-23 13:49:33 PDT
Created attachment 238567 [details] Patch
Chris Dumez
Comment 5 2014-09-23 14:16:32 PDT
Comment on attachment 238567 [details] Patch Yep, this was a flake.
WebKit Commit Bot
Comment 6 2014-09-23 14:21:23 PDT
Comment on attachment 238567 [details] Patch Clearing flags on attachment: 238567 Committed r173891: <http://trac.webkit.org/changeset/173891>
WebKit Commit Bot
Comment 7 2014-09-23 14:21:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.