Bug 137031

Summary: [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
joepeck: review+
Patch none

Jer Noble
Reported 2014-09-23 11:05:39 PDT
[Tools] git-commit uses wrong ChangeLog when run from a subdirectory
Attachments
Patch (1.53 KB, patch)
2014-09-23 11:09 PDT, Jer Noble 		joepeck: review+
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2014-09-23 11:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-09-23 11:09:05 PDT
Created attachment 238548 [details] Patch
Jer Noble
Comment 2 2014-09-23 11:11:19 PDT
Created attachment 238549 [details] Patch
Joseph Pecoraro
Comment 3 2014-09-23 13:10:43 PDT
Comment on attachment 238548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238548&action=review r=me! > Tools/Scripts/commit-log-editor:155 > +@changeLogs = map { $ENV{GIT_PREFIX} . $_} @changeLogs if (isGit()); Nit: Should have a space at the end of the inside block Nit: Unnecessary parens around the if condition when it is at the end of the line: @changeLogs = map { $ENV{GIT_PREFIX} . $_ } @changeLogs if isGit();
Jer Noble
Comment 4 2014-09-23 13:54:28 PDT
Committed r173887: <http://trac.webkit.org/changeset/173887>
Note You need to log in before you can comment on or make changes to this bug.