Bug 137031

Summary:

[Tools] git-commit uses wrong ChangeLog when run from a subdirectory

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	joepeck: review+
Patch	none

Description Jer Noble 2014-09-23 11:05:39 PDT

[Tools] git-commit uses wrong ChangeLog when run from a subdirectory

Comment 1 Jer Noble 2014-09-23 11:09:05 PDT

Created attachment 238548 [details]
Patch

Comment 2 Jer Noble 2014-09-23 11:11:19 PDT

Created attachment 238549 [details]
Patch

Comment 3 Joseph Pecoraro 2014-09-23 13:10:43 PDT

Comment on attachment 238548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238548&action=review

r=me!

> Tools/Scripts/commit-log-editor:155
> +@changeLogs = map { $ENV{GIT_PREFIX} . $_} @changeLogs if (isGit());

Nit: Should have a space at the end of the inside block
Nit: Unnecessary parens around the if condition when it is at the end of the line:

    @changeLogs = map { $ENV{GIT_PREFIX} . $_ } @changeLogs if isGit();

Comment 4 Jer Noble 2014-09-23 13:54:28 PDT

Committed r173887: <http://trac.webkit.org/changeset/173887>