Summary: | [Cocoa] Add UI delegate callback when window.close() is called | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, commit-queue, front.end.developing, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2014-09-22 11:08:53 PDT
Created attachment 238492 [details]
Patch and unit test
Attachment 238492 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:88: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238492 [details] Patch and unit test View in context: https://bugs.webkit.org/attachment.cgi?id=238492&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:70 > + webView.get().configuration.preferences.javaScriptCanOpenWindowsAutomatically = YES; Please use [webView configuration].preferences here instead (In reply to comment #4) > (From update of attachment 238492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238492&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:70 > > + webView.get().configuration.preferences.javaScriptCanOpenWindowsAutomatically = YES; > > Please use [webView configuration].preferences here instead Will fix before landing. Committed r173851: <http://trac.webkit.org/changeset/173851> *** Bug 137423 has been marked as a duplicate of this bug. *** |