Bug 136992

Summary: FTL should store the four bytes of the cell header using a 32-bit store rather than four 8-bit stores
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 136330    
Attachments:
Description Flags
the patch
none
the patch
none
the patch sam: review+

Filip Pizlo
Reported 2014-09-21 21:14:30 PDT
It's totally possible that LLVM was combining these stores. But, I'm about to reorganize this code in a way that might make it harder for LLVM to infer this, so I'd rather make it explicit on the FTL side.
Attachments
the patch (4.70 KB, patch)
2014-09-21 21:19 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (4.08 KB, patch)
2014-09-21 21:20 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (4.84 KB, patch)
2014-09-21 23:17 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-09-21 21:19:28 PDT
Created attachment 238448 [details] the patch
Filip Pizlo
Comment 2 2014-09-21 21:20:34 PDT
Created attachment 238449 [details] the patch For real this time.
Filip Pizlo
Comment 3 2014-09-21 21:21:17 PDT
Comment on attachment 238449 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=238449&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4867 > - > + Reverted locally. > Source/JavaScriptCore/runtime/Structure.h:342 > - > + Reverted locally.
Csaba Osztrogonác
Comment 4 2014-09-21 23:09:22 PDT
(In reply to comment #2) > Created an attachment (id=238449) [details] > the patch > > For real this time. Please add changelog entry for this patch.
Filip Pizlo
Comment 5 2014-09-21 23:14:55 PDT
(In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=238449) [details] [details] > > the patch > > > > For real this time. > > Please add changelog entry for this patch. Oops.
Filip Pizlo
Comment 6 2014-09-21 23:17:33 PDT
Created attachment 238452 [details] the patch Including ChangeLog.
Filip Pizlo
Comment 7 2014-09-22 08:35:40 PDT
Landed in http://trac.webkit.org/changeset/173837
Note You need to log in before you can comment on or make changes to this bug.