Bug 136987

Summary: REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andersca, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
dbates: review+
patch for landing none

Alexey Proskuryakov
Reported 2014-09-21 16:08:11 PDT
http://trac.webkit.org/r172172 made WebKit2 respect primary language for default encoding selection automatically. Before it, a client needed to do something if it wanted the behavior - WebKitTestRunner did not, so it defaulted to ISO-8859-1.
Attachments
proposed fix (97.46 KB, patch)
2014-09-21 16:15 PDT, Alexey Proskuryakov 		dbates: review+
DetailsFormatted DiffDiff
patch for landing (97.46 KB, patch)
2014-10-01 09:52 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-09-21 16:15:19 PDT
Created attachment 238438 [details] proposed fix
Daniel Bates
Comment 2 2014-10-01 09:36:40 PDT
Comment on attachment 238438 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=238438&action=review > LayoutTests/ChangeLog:53 > + Specified the encoding, windows-1252 is what we use for Latin1 and ISO-8851-1 alike. I take it you meant to write ISO-8859-1 instead of ISO-8851-1.
Alexey Proskuryakov
Comment 3 2014-10-01 09:52:52 PDT
Created attachment 239031 [details] patch for landing
WebKit Commit Bot
Comment 4 2014-10-01 10:36:02 PDT
Comment on attachment 239031 [details] patch for landing Clearing flags on attachment: 239031 Committed r174160: <http://trac.webkit.org/changeset/174160>
WebKit Commit Bot
Comment 5 2014-10-01 10:36:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.