Bug 136987

Summary:

REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andersca, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	dbates: review+
patch for landing	none

Description Alexey Proskuryakov 2014-09-21 16:08:11 PDT

http://trac.webkit.org/r172172 made WebKit2 respect primary language for default encoding selection automatically. Before it, a client needed to do something if it wanted the behavior - WebKitTestRunner did not, so it defaulted to ISO-8859-1.

Comment 1 Alexey Proskuryakov 2014-09-21 16:15:19 PDT

Created attachment 238438 [details]
proposed fix

Comment 2 Daniel Bates 2014-10-01 09:36:40 PDT

Comment on attachment 238438 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=238438&action=review

> LayoutTests/ChangeLog:53
> +        Specified the encoding, windows-1252 is what we use for Latin1 and ISO-8851-1 alike.

I take it you meant to write ISO-8859-1 instead of ISO-8851-1.

Comment 3 Alexey Proskuryakov 2014-10-01 09:52:52 PDT

Created attachment 239031 [details]
patch for landing

Comment 4 WebKit Commit Bot 2014-10-01 10:36:02 PDT

Comment on attachment 239031 [details]
patch for landing

Clearing flags on attachment: 239031

Committed r174160: <http://trac.webkit.org/changeset/174160>

Comment 5 WebKit Commit Bot 2014-10-01 10:36:06 PDT

All reviewed patches have been landed.  Closing bug.