Bug 136982

Summary: Web Inspector: fix TypeSet hierarchy in TypeTokenView
Product: WebKit Reporter: Saam Barati <saam>
Component: Web InspectorAssignee: Saam Barati <saam>
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
proposed patch
patch none

Description Saam Barati 2014-09-21 00:45:35 PDT
Take the example program:

var x = {}
x = 2;

The type token displayed next to x will be Object, but it should be many.
Comment 1 Radar WebKit Bug Importer 2014-09-21 00:45:43 PDT
Comment 2 Saam Barati 2014-09-21 00:51:39 PDT
Created attachment 238424 [details]
proposed patch

I think this patch should fix the issue, but I'm waiting on a build to verify.
Comment 3 Saam Barati 2014-09-21 12:20:47 PDT
Argh, it seems like the problem is deeper than this too.
TypeSet::inspectorTypeSet seems to be broken when being passed over the protocol.
I'm looking into fixing this now.
Comment 4 Saam Barati 2014-09-21 13:49:22 PDT
Created attachment 238433 [details]

This should fix the problem:
I was using TypeSet::doesTypeConformTo which checks a bound on a type, it does NOT check whether a TypeSet has ever been a specific type, which is the behavior we want.
Comment 5 Saam Barati 2014-09-21 21:08:15 PDT
Created attachment 238447 [details]
Comment 6 Joseph Pecoraro 2014-09-21 22:04:14 PDT
Comment on attachment 238447 [details]

Oops!!! My fault :O. Should have seen that in review. r=me
Comment 7 WebKit Commit Bot 2014-09-21 23:58:41 PDT
Comment on attachment 238447 [details]

Clearing flags on attachment: 238447

Committed r173805: <http://trac.webkit.org/changeset/173805>
Comment 8 WebKit Commit Bot 2014-09-21 23:58:44 PDT
All reviewed patches have been landed.  Closing bug.