| Summary: | Web Inspector: fix TypeSet hierarchy in TypeTokenView | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | Web Inspector | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 238424 [details]
proposed patch
I think this patch should fix the issue, but I'm waiting on a build to verify.
Argh, it seems like the problem is deeper than this too. TypeSet::inspectorTypeSet seems to be broken when being passed over the protocol. I'm looking into fixing this now. Created attachment 238433 [details]
patch
This should fix the problem:
I was using TypeSet::doesTypeConformTo which checks a bound on a type, it does NOT check whether a TypeSet has ever been a specific type, which is the behavior we want.
Created attachment 238447 [details]
patch
Comment on attachment 238447 [details]
patch
Oops!!! My fault :O. Should have seen that in review. r=me
Comment on attachment 238447 [details] patch Clearing flags on attachment: 238447 Committed r173805: <http://trac.webkit.org/changeset/173805> All reviewed patches have been landed. Closing bug. |
Take the example program: ` var x = {} x = 2; ` The type token displayed next to x will be Object, but it should be many.