Bug 136980

Summary:

Web Inspector: unlocalized 'many' string in type profiler inline bubble

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.nihilogic.dk/labs/tetris/

Attachments:

Description	Flags
patch	burg: review+
patch	none

Description Brian Burg 2014-09-20 23:20:42 PDT

I think this is supposed to be localized, right?

You can see this in action on tetris.js:284

Comment 1 Radar WebKit Bug Importer 2014-09-20 23:20:55 PDT

<rdar://problem/18405527>

Comment 2 Timothy Hatcher 2014-09-20 23:23:21 PDT

It is debatable if they should be localized. We don't localize things that match language keywords or names. (For example the padding, margin, etc. labels in the Style Metrics pane are not localized.)

Comment 3 Saam Barati 2014-09-21 00:16:38 PDT

I think Joe and I spoke about this in a previous bug or over IRC. 

I think it should be localized because many JavaScript programmers will be familiar
with String, Null, etc, just by programming in JavaScript, even though they may not understand
the English meaning of these words. But I don't think non-English speaking programmers will
immediately understand "many".

Comment 4 Saam Barati 2014-09-21 00:19:13 PDT

I guess an argument against my previous point is:

It might be weird from a user experience perspective to have
all type tokens be in English except the "many" token.

Comment 5 Saam Barati 2014-09-21 00:41:45 PDT

Created attachment 238423 [details]
patch

Comment 6 Brian Burg 2014-09-21 18:54:50 PDT

(In reply to comment #4)
> I guess an argument against my previous point is:
> 
> It might be weird from a user experience perspective to have
> all type tokens be in English except the "many" token.

My inclination would be to put it in parens: (many) or call it multiple.

From reading Japanese + code, it's not going to be a big shocker. But this discussion is mostly hypothetical until we get some localizers in the loop.

For now, I think this should land as-is so we can start getting feedback and get rid of LOCALIZED STRING NOT FOUND.

Comment 7 Saam Barati 2014-09-21 19:34:47 PDT

Created attachment 238444 [details]
patch

Including parenthesis in localizable string.

Comment 8 WebKit Commit Bot 2014-09-21 20:42:41 PDT

Comment on attachment 238444 [details]
patch

Clearing flags on attachment: 238444

Committed r173803: <http://trac.webkit.org/changeset/173803>

Comment 9 WebKit Commit Bot 2014-09-21 20:42:44 PDT

All reviewed patches have been landed.  Closing bug.