| Summary: | Remove WinCE port from trunk | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, alex.christensen, bfulgham, commit-queue, ossy, paroga, roger_fong, yong.li.webkit | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Csaba Osztrogonác
2014-09-19 04:43:49 PDT
Created attachment 238372 [details]
WIP patch for EWS
Created attachment 238373 [details]
WIP patch for EWS
Created attachment 238374 [details]
WIP patch for EWS
Created attachment 238435 [details]
WIP patch for EWS - with win fixes
I know this is WIP, but it looks good to me so far. Comment on attachment 238435 [details] WIP patch for EWS - with win fixes View in context: https://bugs.webkit.org/attachment.cgi?id=238435&action=review > Source/WTF/wtf/OSAllocator.h:82 > -inline void OSAllocator::decommitAndRelease(void* releaseBase, size_t releaseSize, void* decommitBase, size_t decommitSize) > +inline void OSAllocator::decommitAndRelease(void* releaseBase, size_t releaseSize, void*, size_t) Maybe we can get rid of these parameters from call sides too. > Source/WebCore/platform/graphics/win/GDIExtras.h:-59 > -#endif We can remove the whole header, because it was included only from Source/WebCore/platform/graphics/win/GDIExtras.cpp. > Source/WebCore/platform/win/COMPtr.h:-40 > -#if !OS(WINCE) > -#include <guiddef.h> > -#endif > - It shouldn't be removed because of the guard, but is seems Windows EWS is still happy. Created attachment 238592 [details] proposed patch addressed my comments in Comment #6 , except the Source/WebCore/platform/win/COMPtr.h change Comment on attachment 238592 [details]
proposed patch
I think this patch is ready for review now.
Comment on attachment 238592 [details]
proposed patch
This looks good, passes the Win EWS, and I just checked that it doesn't break WinCairo. I am disappointed that nobody thinks WinCE is worth maintaining, but I see no reason that this shouldn't go in based on the discussion on webkit-dev. This can always be used as reference later.
Comment on attachment 238592 [details] proposed patch Rejecting attachment 238592 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 238592, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: self._filesystem.open_text_file_for_reading(self.path) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 205, in open_text_file_for_reading return codecs.open(path, 'r', 'utf8', errors) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 881, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: u'/Volumes/Data/EWS/WebKit/Source/WebKit/wince/ChangeLog' Full output: http://webkit-queues.appspot.com/results/6567887099658240 Landed manually in https://trac.webkit.org/changeset/173949 and https://trac.webkit.org/changeset/173950 , because commit-log-editor can't handle the removed Source/WebKit/wince/ChangeLog file. |