Bug 136875

Summary:

Web Inspector: Reduce a bit of churn setting initial remote inspection state

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-09-16 16:53:06 PDT

Currently JSGlobalObjects always set remote inspection enabled in construction, and then JSDOMGlobalObjects would disable it.

Instead move the remote inspection enabling on JSGlobalObjects to the JSContext/JSGlobalContextRef API boundaries. This way the JSGlobalObject within web pages are never temporarily debuggable reducing the amount of churn surrounding toggling this setting.

This does mean that only JSGlobalObjects made through the JSC C/ObjC APIs are debuggable, but that covers the majority. I found only jsc directly instantiates a JSGlobalObject via subclassing.

Comment 1 Radar WebKit Bug Importer 2014-09-16 16:54:17 PDT

<rdar://problem/18359599>

Comment 2 Joseph Pecoraro 2014-09-16 17:01:18 PDT

Created attachment 238221 [details]
[PATCH] Proposed Fix

Comment 3 Timothy Hatcher 2014-09-16 17:06:00 PDT

Comment on attachment 238221 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=238221&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        Set the defaultl remote debuggable state at the API boundary.

Typo: default

Comment 4 WebKit Commit Bot 2014-09-16 17:49:33 PDT

Comment on attachment 238221 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238221

Committed r173683: <http://trac.webkit.org/changeset/173683>

Comment 5 WebKit Commit Bot 2014-09-16 17:49:35 PDT

All reviewed patches have been landed.  Closing bug.