Bug 136865

Summary: Two editing/spelling layout tests are not as robust as they could be
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED    
Severity: Normal CC: dino, jonlee, oliver, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2014-09-16 13:29:16 PDT
editing/spelling/spelling-with-punctuation-selection.html is not as robust as it could be
Attachments
Patch (3.64 KB, patch)
2014-09-16 13:30 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2014-09-16 13:36 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-09-16 13:30:26 PDT
Created attachment 238198 [details] Patch
Myles C. Maxfield
Comment 2 2014-09-16 13:36:06 PDT
Created attachment 238201 [details] Patch
Simon Fraser (smfr)
Comment 3 2014-09-16 13:51:55 PDT
Comment on attachment 238201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238201&action=review > LayoutTests/ChangeLog:3 > + Two editing/spelling layout tests are not as robust as they could be This would be better as "Make spelling tests more reliable by using a word that is misspelled in all English variants" or something.
Myles C. Maxfield
Comment 4 2014-09-16 15:37:13 PDT
http://trac.webkit.org/changeset/173674
Myles C. Maxfield
Comment 5 2014-12-27 08:16:29 PST
It looks like this is supposed to be mocked, so this patch shouldn't have worked. See DumpRenderTree.mm @"wellcome": @"welcome", We should figure out why the mock didn't work.
Note You need to log in before you can comment on or make changes to this bug.