Bug 136865

Summary: Two editing/spelling layout tests are not as robust as they could be
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED ---    
Severity: Normal CC: dino, jonlee, oliver, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Description Myles C. Maxfield 2014-09-16 13:29:16 PDT 
editing/spelling/spelling-with-punctuation-selection.html is not as robust as it could be
Comment 1 Myles C. Maxfield 2014-09-16 13:30:26 PDT 
Created attachment 238198 [details]
Patch
Comment 2 Myles C. Maxfield 2014-09-16 13:36:06 PDT 
Created attachment 238201 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-09-16 13:51:55 PDT 
Comment on attachment 238201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238201&action=review

> LayoutTests/ChangeLog:3
> +        Two editing/spelling layout tests are not as robust as they could be

This would be better as "Make spelling tests more reliable by using a word that is misspelled in all English variants" or something.
Comment 4 Myles C. Maxfield 2014-09-16 15:37:13 PDT 
http://trac.webkit.org/changeset/173674
Comment 5 Myles C. Maxfield 2014-12-27 08:16:29 PST 
It looks like this is supposed to be mocked, so this patch shouldn't have worked. See DumpRenderTree.mm

@"wellcome": @"welcome",

We should figure out why the mock didn't work.