Bug 136862

Summary:

[iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ddkilzer, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Daniel Bates 2014-09-16 12:37:03 PDT

Add a suffix to the iOS WebKitSystemInterface name that includes the SDK name and version.

Comment 1 Daniel Bates 2014-09-16 12:41:43 PDT

Created attachment 238194 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2014-09-16 13:20:26 PDT

Comment on attachment 238194 [details]
Patch

r=me, but I think there is a change that needs to be made to Tools/Scripts/copy-webkitlibraries-to-product-directory to make sure we copy the correct libWebKitSystemInterfaceIOS*.a when building for the iOS Simulator.

Comment 3 Daniel Bates 2014-09-16 13:51:39 PDT

(In reply to comment #2)
> (From update of attachment 238194 [details])
> [...] I think there is a change that needs to be made to Tools/Scripts/copy-webkitlibraries-to-product-directory to make sure we copy the correct libWebKitSystemInterfaceIOS*.a when building for the iOS Simulator.

I plan to do this in another bug.

Comment 4 Daniel Bates 2014-09-16 15:30:05 PDT

Committed r173673: <http://trac.webkit.org/changeset/173673>