| Summary: | [EFL][GTK] Remove WebKit1 related codes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nagy Renátó <rnagy> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ossy, pnormand, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Nagy Renátó
2014-09-16 04:39:58 PDT
Created attachment 238174 [details]
Proposed patch
Comment on attachment 238174 [details]
Proposed patch
It looks like the WinCE port is still a WebKit1 port, so I don't know that everything in this patch is valid. Perhaps I'm misunderstanding something though?
(In reply to comment #2) > (From update of attachment 238174 [details]) > It looks like the WinCE port is still a WebKit1 port, so I don't know that everything in this patch is valid. Perhaps I'm misunderstanding something though? WinCE will be removed from the trunk soon. But it can be fixed easily, they should add a "set(ENABLE_WEBKIT2 OFF)" line to the Source/cmake/OptionsWinCE.cmake not to try to build the non-existent WebKit2 port. Other parts of the patch shouldn't affect the WinCE port. Comment on attachment 238174 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=238174&action=review LGTM, with a little nit. > Tools/Scripts/webkitpy/port/gtk.py:213 > + def test_expectations_file_position(self): > + return 2 It would be great to have a similar comment to efl.py here. Created attachment 238238 [details]
Proposed patch
Added missing comment to test_expectations_file_position
Comment on attachment 238238 [details] Proposed patch Clearing flags on attachment: 238238 Committed r173689: <http://trac.webkit.org/changeset/173689> All reviewed patches have been landed. Closing bug. |