Bug 136853

Summary:

[EFL][GTK] Remove WebKit1 related codes

Product:

WebKit

Reporter:

Nagy Renátó <rnagy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ossy, pnormand, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	ossy: review+, ossy: commit-queue-
Proposed patch	none

Nagy Renátó

Reported 2014-09-16 04:39:58 PDT

Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted from scripts.

Attachments
Proposed patch (19.76 KB, patch) 2014-09-16 04:45 PDT, Nagy Renátó	ossy: review+ ossy: commit-queue-	Details Formatted Diff Diff
Proposed patch (19.93 KB, patch) 2014-09-16 23:52 PDT, Nagy Renátó	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Nagy Renátó

Comment 1 2014-09-16 04:45:10 PDT

Created attachment 238174 [details] Proposed patch

Martin Robinson

Comment 2 2014-09-16 06:31:26 PDT

Comment on attachment 238174 [details] Proposed patch It looks like the WinCE port is still a WebKit1 port, so I don't know that everything in this patch is valid. Perhaps I'm misunderstanding something though?

Csaba Osztrogonác

Comment 3 2014-09-16 06:52:49 PDT

(In reply to comment #2) > (From update of attachment 238174 [details]) > It looks like the WinCE port is still a WebKit1 port, so I don't know that everything in this patch is valid. Perhaps I'm misunderstanding something though? WinCE will be removed from the trunk soon. But it can be fixed easily, they should add a "set(ENABLE_WEBKIT2 OFF)" line to the Source/cmake/OptionsWinCE.cmake not to try to build the non-existent WebKit2 port. Other parts of the patch shouldn't affect the WinCE port.

Csaba Osztrogonác

Comment 4 2014-09-16 06:58:54 PDT

Comment on attachment 238174 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=238174&action=review LGTM, with a little nit. > Tools/Scripts/webkitpy/port/gtk.py:213 > + def test_expectations_file_position(self): > + return 2 It would be great to have a similar comment to efl.py here.

Nagy Renátó

Comment 5 2014-09-16 23:52:51 PDT

Created attachment 238238 [details] Proposed patch Added missing comment to test_expectations_file_position

WebKit Commit Bot

Comment 6 2014-09-17 02:29:37 PDT

Comment on attachment 238238 [details] Proposed patch Clearing flags on attachment: 238238 Committed r173689: <http://trac.webkit.org/changeset/173689>

WebKit Commit Bot

Comment 7 2014-09-17 02:29:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.