Summary: | W3C test importer should copy .htaccess files | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Tools / Tests | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bjonesbe, commit-queue, glenn, rhauck | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2014-09-16 03:18:07 PDT
Created attachment 238171 [details]
Patch
Comment on attachment 238171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238171&action=review > Tools/Scripts/webkitpy/w3c/test_importer.py:184 > if filename.startswith('.') or filename.endswith('.pl'): > - continue # For some reason the w3c repo contains random perl scripts we don't care about. > + if not filename == '.htaccess': > + continue # For some reason the w3c repo contains random perl scripts we don't care about. This is getting messy. I would add a helper like should_skip_file(), and move all of the tests there. Then this would be something like: if self.should_skip_file(filename): continue Created attachment 238520 [details]
Added helper function
Comment on attachment 238520 [details]
Added helper function
r=me
Comment on attachment 238520 [details] Added helper function Clearing flags on attachment: 238520 Committed r173876: <http://trac.webkit.org/changeset/173876> All reviewed patches have been landed. Closing bug. |