Bug 136850 – W3C test importer should copy .htaccess files

• Component: Tools / Tests
• Status: RESOLVED FIXED

[youenn fablet]

Currently W3C test import skip all files starting with '.'
.htaccess is used to control serving files on HTTP and should be copied.

[youenn fablet]

Created attachment 238171 [details]
Patch

[Bem Jones-Bey]

Comment on attachment 238171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238171&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:184
>                  if filename.startswith('.') or filename.endswith('.pl'):
> -                    continue  # For some reason the w3c repo contains random perl scripts we don't care about.
> +                    if not filename == '.htaccess':
> +                        continue  # For some reason the w3c repo contains random perl scripts we don't care about.

This is getting messy. I would add a helper like should_skip_file(), and move all of the tests there. Then this would be something like:
if self.should_skip_file(filename):
  continue

[youenn fablet]

Created attachment 238520 [details]
Added helper function

[Bem Jones-Bey]

Comment on attachment 238520 [details]
Added helper function

r=me

[WebKit Commit Bot]

Comment on attachment 238520 [details]
Added helper function

Clearing flags on attachment: 238520

Committed r173876: <http://trac.webkit.org/changeset/173876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.