Bug 136845

Summary:

Add parsing for :nth-child(An+B of selector)

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

7raivis, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2014-09-15 19:52:53 PDT

Add parsing for :nth-child(An+B of selector)

Comment 1 Benjamin Poulain 2014-09-15 20:12:05 PDT

Created attachment 238153 [details]
Patch

Comment 2 Antti Koivisto 2014-09-17 12:38:08 PDT

Comment on attachment 238153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238153&action=review

> Source/WebCore/css/CSSParserValues.cpp:294
> +    for (const CSSSelector* subSelector = selectorList->first(); subSelector; subSelector = CSSSelectorList::next(subSelector)) {

We should come up with iterators for this stuff :|

Comment 3 Benjamin Poulain 2014-09-17 13:37:45 PDT

Comment on attachment 238153 [details]
Patch

Clearing flags on attachment: 238153

Committed r173698: <http://trac.webkit.org/changeset/173698>

Comment 4 Benjamin Poulain 2014-09-17 13:37:48 PDT

All reviewed patches have been landed.  Closing bug.