Bug 136844

Summary: Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-09-15 16:53:27 PDT
Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches() for clarity as the argument is an Element.
Attachments
Patch (21.39 KB, patch)
2014-09-15 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-15 16:55:13 PDT
Created attachment 238148 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-15 22:36:50 PDT
Comment on attachment 238148 [details] Patch Clearing flags on attachment: 238148 Committed r173649: <http://trac.webkit.org/changeset/173649>
WebKit Commit Bot
Comment 3 2014-09-15 22:36:54 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2014-09-17 17:23:08 PDT
Comment on attachment 238148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238148&action=review > Source/WebCore/dom/ClassNodeList.h:49 > + virtual bool elementMatches(Element*) const override; Since we are touching every single call site, it really seems we’d want to change this to Element&. Too late!
Chris Dumez
Comment 5 2014-09-17 17:42:24 PDT
Comment on attachment 238148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238148&action=review >> Source/WebCore/dom/ClassNodeList.h:49 >> + virtual bool elementMatches(Element*) const override; > > Since we are touching every single call site, it really seems we’d want to change this to Element&. Too late! Right, sorry about that. I'll follow-up on this.
Note You need to log in before you can comment on or make changes to this bug.