Bug 136838

Summary: Return early in SelectorChecker::checkOne() if selector.isAttributeSelector() is true
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-09-15 14:26:06 PDT
Return early in SelectorChecker::checkOne() if selector.isAttributeSelector() is true and the selector matched. Previously, we were only returning early if the selector did not match and we were falling through if it did. This means that we ended up doing the 2 if() checks below in the method unnecessarily: - selector.m_match == CSSSelector::PseudoClass - selector.m_match == CSSSelector::PseudoElement
Attachments
Patch (1.99 KB, patch)
2014-09-15 14:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-15 14:28:16 PDT
Created attachment 238142 [details] Patch
Benjamin Poulain
Comment 2 2014-09-15 17:01:55 PDT
Comment on attachment 238142 [details] Patch Please do not optimize SelectorChecker, it is *completely* untested. The rule for SelectorChecker is now to make it correct no matter how slow "correct" is.
WebKit Commit Bot
Comment 3 2014-09-15 19:30:25 PDT
Comment on attachment 238142 [details] Patch Clearing flags on attachment: 238142 Committed r173646: <http://trac.webkit.org/changeset/173646>
WebKit Commit Bot
Comment 4 2014-09-15 19:30:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.