Bug 136824

Summary: [EFL][CoordinatedGraphics] Remove setBackgroundColor message
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, hw1008.kim, lucas.de.marchi, yoon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2014-09-15 08:39:43 PDT
pageExtendedBackgroundColor in WebPageProxy provides similar functionality.
Attachments
Patch (19.56 KB, patch)
2014-09-15 08:53 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-09-15 08:53:23 PDT
Created attachment 238130 [details] Patch
Gyuyoung Kim
Comment 2 2014-09-15 10:00:12 PDT
Comment on attachment 238130 [details] Patch Now I understand that setBackgroundColor() is used by Coordinated Graphics, and pageExtendedBackgroundColor() is supported by Mac or iOS port. However, it is same functionality. If so, I agree to use pageExtendedBackgroundColor(). Though I want to test layout test with pixel-test, unfortunately EFL port doesn't support the pixel test yet. I wonder how does yoon think about this refactor patch.
Ryuan Choi
Comment 3 2014-09-17 22:02:10 PDT
hyowon, could you take a look at this?
Gyuyoung Kim
Comment 4 2014-09-18 21:06:23 PDT
Comment on attachment 238130 [details] Patch I think it is a our way to share common interface or function. In this case, pageExtendedBackgroundColor() is being used by WK2's mac port. So, I would set r+ed for this refactoring.
WebKit Commit Bot
Comment 5 2014-09-18 21:41:54 PDT
Comment on attachment 238130 [details] Patch Clearing flags on attachment: 238130 Committed r173748: <http://trac.webkit.org/changeset/173748>
WebKit Commit Bot
Comment 6 2014-09-18 21:42:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.