Bug 136824

Summary: [EFL][CoordinatedGraphics] Remove setBackgroundColor message
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, hw1008.kim, lucas.de.marchi, yoon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ryuan Choi 2014-09-15 08:39:43 PDT 
pageExtendedBackgroundColor in WebPageProxy provides similar functionality.
Comment 1 Ryuan Choi 2014-09-15 08:53:23 PDT 
Created attachment 238130 [details]
Patch
Comment 2 Gyuyoung Kim 2014-09-15 10:00:12 PDT 
Comment on attachment 238130 [details]
Patch

Now I understand that setBackgroundColor() is used by Coordinated Graphics, and pageExtendedBackgroundColor() is supported by Mac or iOS port. However, it is same functionality. If so, I agree to use pageExtendedBackgroundColor(). Though I want to test layout test with pixel-test, unfortunately EFL port doesn't support the pixel test yet. I wonder how does yoon think about this refactor patch.
Comment 3 Ryuan Choi 2014-09-17 22:02:10 PDT 
hyowon, could you take a look at this?
Comment 4 Gyuyoung Kim 2014-09-18 21:06:23 PDT 
Comment on attachment 238130 [details]
Patch

I think it is a our way to share common interface or function. In this case, pageExtendedBackgroundColor() is being used by WK2's mac port. So, I would set r+ed for this refactoring.
Comment 5 WebKit Commit Bot 2014-09-18 21:41:54 PDT 
Comment on attachment 238130 [details]
Patch

Clearing flags on attachment: 238130

Committed r173748: <http://trac.webkit.org/changeset/173748>
Comment 6 WebKit Commit Bot 2014-09-18 21:42:02 PDT 
All reviewed patches have been landed.  Closing bug.