Bug 136821

Summary:

Remove ORWT related crufts from webkitdirs.pm

Product:

WebKit

Reporter:

Tibor Mészáros <mtiborinf>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, gyuyoung.kim, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tibor Mészáros 2014-09-15 05:31:59 PDT

old-run-webkit-tests was removed from trunk by http://trac.webkit.org/changeset/171967, so we can remove ORWT related crufts from webkitdirs.pm.

Comment 1 Tibor Mészáros 2014-09-15 05:34:37 PDT

Created attachment 238122 [details]
Patch

This patch will removed ORWT related crufts from webkitdirs.pm.

Comment 2 Alexey Proskuryakov 2014-09-15 20:13:13 PDT

Comment on attachment 238122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238122&action=review

r=me assuming that webkitperl tests passed (test-webkitperl). EWS doesn't run these.

> Tools/Scripts/webkitdirs.pm:-1184
> -sub isPerianInstalled()

Interesting - there was recently a conjecture that tests fail on some machines because of Perian. Perhaps we should start checking for it in nrwt.

Comment 3 WebKit Commit Bot 2014-09-15 20:50:22 PDT

Comment on attachment 238122 [details]
Patch

Clearing flags on attachment: 238122

Committed r173647: <http://trac.webkit.org/changeset/173647>

Comment 4 WebKit Commit Bot 2014-09-15 20:50:25 PDT

All reviewed patches have been landed.  Closing bug.