Bug 136819

Summary: Move DragController::createFragmentFromDragData implementation to the editor
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136802    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Updated patch
none
Try to fix windows build
none
Try to fix EFL build
darin: review+
Patch for landing none

Carlos Garcia Campos
Reported 2014-09-15 05:02:39 PDT
And use the editor from the DragController instead.
Attachments
Patch (15.34 KB, patch)
2014-09-15 05:09 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (16.17 KB, patch)
2014-09-17 00:24 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix windows build (16.22 KB, patch)
2014-09-17 01:19 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix EFL build (16.42 KB, patch)
2014-09-17 02:03 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (16.36 KB, patch)
2014-10-04 00:44 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-09-15 05:09:06 PDT
Created attachment 238117 [details] Patch
Carlos Garcia Campos
Comment 2 2014-09-17 00:24:27 PDT
Created attachment 238239 [details] Updated patch Rebased, it should apply now
Carlos Garcia Campos
Comment 3 2014-09-17 01:19:13 PDT
Created attachment 238240 [details] Try to fix windows build
Carlos Garcia Campos
Comment 4 2014-09-17 02:03:10 PDT
Created attachment 238243 [details] Try to fix EFL build
Carlos Garcia Campos
Comment 5 2014-09-29 00:32:29 PDT
Ping :-)
Darin Adler
Comment 6 2014-10-03 09:05:46 PDT
Comment on attachment 238243 [details] Try to fix EFL build View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time. > Source/WebCore/editing/win/EditorWin.cpp:51 > +template <typename PlatformDragData> > +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame) Should take PlatformDragData& instead of PlatformDragData*. I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!?
Carlos Garcia Campos
Comment 7 2014-10-03 09:18:44 PDT
(In reply to comment #6) > (From update of attachment 238243 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review > > A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time. Thanks for the review. > > Source/WebCore/editing/win/EditorWin.cpp:51 > > +template <typename PlatformDragData> > > +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame) > > Should take PlatformDragData& instead of PlatformDragData*. Sure. > I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!? Yes.
Carlos Garcia Campos
Comment 8 2014-10-04 00:44:26 PDT
Created attachment 239271 [details] Patch for landing Not sure the windows changes are correct...
Carlos Garcia Campos
Comment 9 2014-10-04 01:38:09 PDT
Committed r174314: <http://trac.webkit.org/changeset/174314>
Note You need to log in before you can comment on or make changes to this bug.