Summary: | Web Inspector: InjectedScripts should not be profiled or displayed in Timeline | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 136805 | ||||||||
Bug Blocks: | 136292 | ||||||||
Attachments: |
|
Description
Brian Burg
2014-09-14 11:46:49 PDT
Good point. We do hide the InjectedScript from backtraces in the Debugger. We should be able to do it for the profiler too. It would make sense to show it for Inspector^2. That would be via the PageGroup identifier. (In reply to comment #2) > Good point. We do hide the InjectedScript from backtraces in the Debugger. We should be able to do it for the profiler too. > > It would make sense to show it for Inspector^2. That would be via the PageGroup identifier. The profiler can distinguish different page group ids, but I don't think the inspector "level" is exposed anywhere outside of UIProcess. What's a good way to expose that? WebInspectorClient? My WIP patch has a ProfileGenerator::setSuspended flag that is set and unset under the InspectorController will/didCallInjectedScript. Created attachment 238621 [details]
WIP
Comment on attachment 238621 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=238621&action=review Makes sense to me. > Source/WebCore/inspector/InspectorController.cpp:-427 > - InspectorInstrumentationCookie cookie = InspectorInstrumentation::willCallFunction(scriptExecutionContext, scriptName, scriptLine); Yeah I never understood why this was instrumented. Created attachment 238895 [details]
Patch
Attachment 238895 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/profiler/ProfileGenerator.cpp:53: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238895 [details] Patch Clearing flags on attachment: 238895 Committed r174095: <http://trac.webkit.org/changeset/174095> All reviewed patches have been landed. Closing bug. |