| Summary: | Mac queue slaves should reboot every so often | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, lforschler, matthew_hanson | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2014-09-12 15:29:33 PDT
Created attachment 238067 [details]
Fixes the bug
Comment on attachment 238067 [details]
Fixes the bug
Ideally, it would only reboot at night, so that this doesn't happen when someone is logged into the machine, investigating something.
I don't know how to even formally express the wish though.
Maybe we could target a range of time to update... say between 3am and 6am. Then, select our 'time to reboot' to fall into that range. Yeah, or the first time we finished past midnight? Created attachment 238210 [details]
Reboot between 1am and 6am
Comment on attachment 238210 [details] Reboot between 1am and 6am View in context: https://bugs.webkit.org/attachment.cgi?id=238210&action=review > Tools/ChangeLog:8 > + Reboot Mac queue slaves every 12 hours between 1 A.M. and 6 A.M. The end result would be closer to every 24 hours than every 12 hours, wouldn't it? I'd just say "every night between 1am and 6am". > Tools/EWSTools/start-queue-mac.sh:41 > +TIME_TO_REBOOT=$(( $(date +%s) + 3600 * 12)) # Reboot every 12 hours between 1am and 6am. Perhaps a "why" comment would help here (we only want to reboot at night to reduce the likelihood of confusing unexpected things happening while people are looking). Committed r173671: <http://trac.webkit.org/changeset/173671> So the bot will only reboot if it happens to finish during this time period - it will not if it was idle all night, correct? |