Bug 136791

Summary: Mac queue slaves should reboot every so often
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, lforschler, matthew_hanson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Reboot between 1am and 6am ap: review+

Ryosuke Niwa
Reported 2014-09-12 15:29:33 PDT
Right now, Mac EWS, commit queue, etc... don't reboot ever. Reboot them every 24 hours to keep the sanity.
Attachments
Fixes the bug (1.53 KB, patch)
2014-09-12 15:31 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Reboot between 1am and 6am (1.62 KB, patch)
2014-09-16 14:23 PDT, Ryosuke Niwa 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-09-12 15:31:34 PDT
Created attachment 238067 [details] Fixes the bug
Alexey Proskuryakov
Comment 2 2014-09-12 15:56:57 PDT
Comment on attachment 238067 [details] Fixes the bug Ideally, it would only reboot at night, so that this doesn't happen when someone is logged into the machine, investigating something. I don't know how to even formally express the wish though.
Lucas Forschler
Comment 3 2014-09-12 16:00:38 PDT
Maybe we could target a range of time to update... say between 3am and 6am. Then, select our 'time to reboot' to fall into that range.
Ryosuke Niwa
Comment 4 2014-09-12 16:27:39 PDT
Yeah, or the first time we finished past midnight?
Ryosuke Niwa
Comment 5 2014-09-16 14:23:43 PDT
Created attachment 238210 [details] Reboot between 1am and 6am
Alexey Proskuryakov
Comment 6 2014-09-16 14:51:09 PDT
Comment on attachment 238210 [details] Reboot between 1am and 6am View in context: https://bugs.webkit.org/attachment.cgi?id=238210&action=review > Tools/ChangeLog:8 > + Reboot Mac queue slaves every 12 hours between 1 A.M. and 6 A.M. The end result would be closer to every 24 hours than every 12 hours, wouldn't it? I'd just say "every night between 1am and 6am". > Tools/EWSTools/start-queue-mac.sh:41 > +TIME_TO_REBOOT=$(( $(date +%s) + 3600 * 12)) # Reboot every 12 hours between 1am and 6am. Perhaps a "why" comment would help here (we only want to reboot at night to reduce the likelihood of confusing unexpected things happening while people are looking).
Ryosuke Niwa
Comment 7 2014-09-16 15:15:08 PDT
Committed r173671: <http://trac.webkit.org/changeset/173671>
Alexey Proskuryakov
Comment 8 2014-09-25 23:15:05 PDT
So the bot will only reboot if it happens to finish during this time period - it will not if it was idle all night, correct?
Note You need to log in before you can comment on or make changes to this bug.