Bug 136785

Summary:

Add JSCallee to program and eval CallFrames

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, fpizlo, ggaren, mark.lam, mmirman, oliver, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

136724

Attachments:

Description	Flags
Patch	mark.lam: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch with fixes for layout test failures	mark.lam: review+

Description Michael Saboff 2014-09-12 10:26:32 PDT

Currently the JSCallee slot for program and call eval CallFrames is left as null.  These should be populated with a JSCallee in preparation for removing JSScope from the CallFrame.

Comment 1 Michael Saboff 2014-09-12 12:50:01 PDT

Created attachment 238047 [details]
Patch

Comment 2 Mark Lam 2014-09-12 13:03:07 PDT

Comment on attachment 238047 [details]
Patch

r=me

Comment 3 Build Bot 2014-09-12 14:22:02 PDT

Comment on attachment 238047 [details]
Patch

Attachment 238047 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5706141589831680

New failing tests:
fast/profiler/stop-then-function-call.html

Comment 4 Build Bot 2014-09-12 14:22:05 PDT

Created attachment 238059 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 5 Build Bot 2014-09-12 15:00:18 PDT

Comment on attachment 238047 [details]
Patch

Attachment 238047 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6504123964850176

New failing tests:
fast/profiler/stop-then-function-call.html

Comment 6 Build Bot 2014-09-12 15:00:23 PDT

Created attachment 238062 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 7 Build Bot 2014-09-12 15:21:58 PDT

Comment on attachment 238047 [details]
Patch

Attachment 238047 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5442676484734976

New failing tests:
fast/profiler/stop-then-function-call.html

Comment 8 Build Bot 2014-09-12 15:22:02 PDT

Created attachment 238065 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 9 Build Bot 2014-09-12 16:20:17 PDT

Comment on attachment 238047 [details]
Patch

Attachment 238047 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6725690590232576

New failing tests:
fast/profiler/stop-then-function-call.html

Comment 10 Build Bot 2014-09-12 16:20:21 PDT

Created attachment 238073 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 11 Michael Saboff 2014-09-12 17:15:35 PDT

Created attachment 238078 [details]
Patch with fixes for layout test failures

Comment 12 Mark Lam 2014-09-12 17:26:36 PDT

Comment on attachment 238078 [details]
Patch with fixes for layout test failures

r=me

Comment 13 Michael Saboff 2014-09-12 22:21:59 PDT

Committed r173600: <http://trac.webkit.org/changeset/173600>