Summary: | Make all CSSSelector data members private | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2014-09-12 09:52:55 PDT
Created attachment 238036 [details]
Patch
Comment on attachment 238036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238036&action=review Really neat. That is something I wanted for a while but I was too lazy to fix everything :) It is a little sad we need the public setters for the parser. I guess in the future we could refactor those out. > Source/WebCore/css/CSSSelector.cpp:87 > // FIXME: Pseudo-elements and pseudo-classes do not have the same specificity. This function > // isn't quite correct. Hum, we should fix that at some point. > Source/WebCore/css/CSSSelector.h:211 > + ASSERT(m_pseudoType == pseudoElementType); I assume you are asserting in case the type become larger than the bit field? > Source/WebCore/css/CSSSelector.h:214 > + void setPagePseudoType(PagePseudoClassType pagePseudoType) You could move this one next to its getter. Comment on attachment 238036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238036&action=review >> Source/WebCore/css/CSSSelector.h:211 >> + ASSERT(m_pseudoType == pseudoElementType); > > I assume you are asserting in case the type become larger than the bit field? Yes, I explained it in the Changelog. >> Source/WebCore/css/CSSSelector.h:214 >> + void setPagePseudoType(PagePseudoClassType pagePseudoType) > > You could move this one next to its getter. Will do. Created attachment 238041 [details]
Patch
(In reply to comment #3) > (From update of attachment 238036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238036&action=review > > >> Source/WebCore/css/CSSSelector.h:211 > >> + ASSERT(m_pseudoType == pseudoElementType); > > > > I assume you are asserting in case the type become larger than the bit field? > > Yes, I explained it in the Changelog. You are assuming I can read properly ;) Comment on attachment 238041 [details] Patch Clearing flags on attachment: 238041 Committed r173569: <http://trac.webkit.org/changeset/173569> All reviewed patches have been landed. Closing bug. |