Bug 136782

Summary: [GTK] String changes for the HTTP authentication dialog
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mrobinson, sun.shin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2014-09-12 09:30:14 PDT
There are a few more changes I want to make for our HTTP authentication dialog. These should not be committed until after 2.6 has been branched, since there are string changes.
Attachments
Patch (6.16 KB, patch)
2014-09-12 09:40 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2014-09-12 09:47 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2014-09-12 09:40:46 PDT
Created attachment 238034 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-12 09:41:37 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2014-09-12 09:47:47 PDT
Created attachment 238035 [details] Patch Make it easier to translate the server message string
WebKit Commit Bot
Comment 4 2014-12-11 11:22:56 PST
Comment on attachment 238035 [details] Patch Clearing flags on attachment: 238035 Committed r177161: <http://trac.webkit.org/changeset/177161>
WebKit Commit Bot
Comment 5 2014-12-11 11:22:59 PST
All reviewed patches have been landed. Closing bug.
Byungseon(Sun) Shin
Comment 6 2014-12-13 02:26:37 PST
I have GTK build error after this change. I have created fix for it on <https://bugs.webkit.org/show_bug.cgi?id=139620>.
Note You need to log in before you can comment on or make changes to this bug.