Bug 136767

Summary: Remove unnecessary overloads taking a ContainerNode in Element Traversal
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, darin, esprehn+autocc, kangil.han, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2014-09-11 17:17:38 PDT 
Remove unnecessary overloads taking a ContainerNode in Element Traversal. Several of those don't bring any performance improvements as the needed methods are defined on Node (not ContainerNode).
Comment 1 Chris Dumez 2014-09-11 17:23:33 PDT 
Created attachment 238001 [details]
Patch
Comment 2 Darin Adler 2014-09-14 12:34:07 PDT 
Comment on attachment 238001 [details]
Patch

It’s OK to do this, the benefits are tiny but there’s nothing wrong with doing it.

It’s annoying that there’s nothing that tests this. Someone could break the performance here and we’d never notice.
Comment 3 WebKit Commit Bot 2014-09-14 15:22:43 PDT 
Comment on attachment 238001 [details]
Patch

Rejecting attachment 238001 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 238001, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   50b7833..5b94a22  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 173606 = 50b7833685ce1e4e389bf97b6c1eca701f187895
r173607 = 5b94a22ed58e34eafddc871496c780cf9397a8e8
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5535136393199616
Comment 4 Chris Dumez 2014-09-14 18:40:52 PDT 
Created attachment 238099 [details]
Patch
Comment 5 WebKit Commit Bot 2014-09-14 19:23:08 PDT 
Comment on attachment 238099 [details]
Patch

Clearing flags on attachment: 238099

Committed r173609: <http://trac.webkit.org/changeset/173609>
Comment 6 WebKit Commit Bot 2014-09-14 19:23:13 PDT 
All reviewed patches have been landed.  Closing bug.