Summary: | Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Farler <dfarler> | ||||||||
Component: | Tools / Tests | Assignee: | David Farler <dfarler> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, dburkart, ddkilzer, dino, kondapallykalyan, mrowe, roger_fong, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
David Farler
2014-09-11 16:22:50 PDT
Dana, isn't this why ASan roots build incorrectly? (In reply to comment #1) > Dana, isn't this why ASan roots build incorrectly? Could be. I will test this theory out. Created attachment 245411 [details]
This patch moves all of the ASan environment variables
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Attachment 245411 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245412 [details]
Fix style issue
Comment on attachment 245412 [details]
Fix style issue
Why do some of these also include $(inherited) but others don’t?
Comment on attachment 245412 [details] Fix style issue View in context: https://bugs.webkit.org/attachment.cgi?id=245412&action=review This breaks the build: "recursive template instantiation exceeded maximum depth". That's caused by losing this option from DebugRelease.xcconfig in TestWebKitAPI: OTHER_CPLUSPLUSFLAGS = -ftemplate-depth=256 $(ASAN_OTHER_CPLUSPLUSFLAGS); Grepping for OTHER_ in WebKit, I noticed that DumpRenderTree.xcodeproj overrides some of these flags to empty in its "All" target. Is this just accidental noise? Can it be deleted? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:30365 > - OTHER_LDFLAGS = ""; > + OTHER_LDFLAGS = "$(ASAN_OTHER_LDFLAGS)"; The WebCoreExportFileGenerator target configuration looks super weird. We should probably give it its own xcconfig file, rather than use WebCore.xcconfig and then override its values. (In reply to comment #8) > Comment on attachment 245412 [details] > Fix style issue > > Why do some of these also include $(inherited) but others don’t? I'm not sure. All of the projects with DebugRelease.xcconfigs which had $(inherited) don't set the environment variables anywhere else, so I guess they were there just to be safe? (In reply to comment #9) > Comment on attachment 245412 [details] > Fix style issue > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245412&action=review > > This breaks the build: "recursive template instantiation exceeded maximum > depth". > > That's caused by losing this option from DebugRelease.xcconfig in > TestWebKitAPI: > > OTHER_CPLUSPLUSFLAGS = -ftemplate-depth=256 $(ASAN_OTHER_CPLUSPLUSFLAGS); > Okay, I'll put that back in. > Grepping for OTHER_ in WebKit, I noticed that DumpRenderTree.xcodeproj > overrides some of these flags to empty in its "All" target. Is this just > accidental noise? Can it be deleted? I think so. I'll give it a shot. > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:30365 > > - OTHER_LDFLAGS = ""; > > + OTHER_LDFLAGS = "$(ASAN_OTHER_LDFLAGS)"; > > The WebCoreExportFileGenerator target configuration looks super weird. We > should probably give it its own xcconfig file, rather than use > WebCore.xcconfig and then override its values. The other targets in WebCore set it to $(ASAN_OTHER_LDFLAGS) instead of being empty, so I simply changed it to match... > The other targets in WebCore set it to $(ASAN_OTHER_LDFLAGS) instead of being empty, so I simply changed it to match...
Right, I don't think that factoring out an xcconfig for this target should be part of this patch.
Created attachment 245493 [details]
Address concerns
Committed revision 179269. |