Bug 136764

Summary: Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, esprehn+autocc, kangil.han, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-09-11 16:00:03 PDT 
Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode in argument. This one does not bring any performance improvement because nextSibling() is defined on Node and nextAncestorSibling() takes a Node in argument.
Comment 1 Chris Dumez 2014-09-11 16:11:15 PDT 
Created attachment 237994 [details]
Patch
Comment 2 Chris Dumez 2014-09-11 16:15:20 PDT 
Comment on attachment 237994 [details]
Patch

I'll get rid of the one on ElementTraversal as well in the same patch.
Comment 3 Chris Dumez 2014-09-11 16:24:10 PDT 
Created attachment 237995 [details]
Patch
Comment 4 Chris Dumez 2014-09-11 16:37:26 PDT 
Created attachment 237997 [details]
Patch
Comment 5 Darin Adler 2014-09-14 12:35:37 PDT 
Comment on attachment 237997 [details]
Patch

Seems fine, but the fact that we can’t easily test is unfortunate.
Comment 6 WebKit Commit Bot 2014-09-14 15:19:26 PDT 
Comment on attachment 237997 [details]
Patch

Clearing flags on attachment: 237997

Committed r173607: <http://trac.webkit.org/changeset/173607>
Comment 7 WebKit Commit Bot 2014-09-14 15:19:31 PDT 
All reviewed patches have been landed.  Closing bug.