Bug 136763 – Simplify DOM tree traversal in FrameSelection::setSelectionFromNone()

• Component: HTML Editing
• Status: RESOLVED FIXED

[Chris Dumez]

Simplify DOM Tree traversal in FrameSelection::setSelectionFromNone(). We only need to traverse the direct children of the Document element to find the body. The previous code was potentially traversing descendants.
The new code is consistent with Document::body() except that we only look for an HTMLBodyElement (and ignore HTMLFrameSetElement).

[Chris Dumez]

Created attachment 237992 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 237992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review

> Source/WebCore/editing/FrameSelection.cpp:2117
> +    Element* documentElement = document->documentElement();
> +    if (!documentElement)
> +        return;

If I were you, I'd declare documentElement inside the if condition and nest the if's.

[WebKit Commit Bot]

Comment on attachment 237992 [details]
Patch

Clearing flags on attachment: 237992

Committed r173549: <http://trac.webkit.org/changeset/173549>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 237992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review

> Source/WebCore/editing/FrameSelection.cpp:2115
> +    Element* documentElement = document->documentElement();

In a case like this I prefer to use auto*. Later we might make the documentElement() function return a more specific type and it would be nice not to have to visit this call site.

[Chris Dumez]

Comment on attachment 237992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review

>> Source/WebCore/editing/FrameSelection.cpp:2115
>> +    Element* documentElement = document->documentElement();
> 
> In a case like this I prefer to use auto*. Later we might make the documentElement() function return a more specific type and it would be nice not to have to visit this call site.

Ok, it makes sense. Would you like me to land another patch for the nit fix or is this for future reference?