Bug 136759

Summary:

Web Inspector: remind about rebaselining generator test results

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn, graouts, joepeck, llango.u-szeged, mattbaker, ossy, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+

Description Brian Burg 2014-09-11 13:58:49 PDT

paths that should trigger:

inspector generator: Source/JavaScriptCore/inspector/scripts/codegen/
replay input generator: Source/JavaScriptCore/replay/scripts/

Comment 1 Brian Burg 2014-09-11 13:59:54 PDT

Relevant scripts:

Tools/Scripts/run-inspector-generator-tests
Tools/Scripts/run-input-generator-tests

Comment 2 Radar WebKit Bug Importer 2014-09-12 14:10:42 PDT

<rdar://problem/18324319>

Comment 3 Brian Burg 2014-09-12 14:21:17 PDT

Created attachment 238058 [details]
Patch

Comment 4 Joseph Pecoraro 2014-09-12 14:39:41 PDT

Comment on attachment 238058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:203
> +            "filename": r"Source/JavaScriptCore/inspector/scripts/codegen",

We may also want the generator script itself:

    Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py

> Tools/Scripts/webkitpy/common/config/watchlist:394
> +        "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ]

Throw a trailing comma! The others have it, and it makes future diffs much nicer =)

Comment 5 Brian Burg 2014-09-12 17:18:30 PDT

(In reply to comment #4)
> (From update of attachment 238058 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:203
> > +            "filename": r"Source/JavaScriptCore/inspector/scripts/codegen",
> 
> We may also want the generator script itself:
> 
>     Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:394
> > +        "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ]
> 
> Throw a trailing comma! The others have it, and it makes future diffs much nicer =)

OK

Comment 6 Brian Burg 2014-09-12 17:35:36 PDT

Committed r173594: <http://trac.webkit.org/changeset/173594>