Bug 136754
| Summary: | [Interop 2021][META] [css-flexbox] Failing some official flexbox tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, chavarria1991, clopez, matthew_hanson, mcatanzaro, phiw2, simon.fraser, svillar, webkit-bug-importer, webkit |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=236680 | ||
| Bug Depends on: | 210243, 221472, 221473, 221474, 221477, 221478, 221481, 221482, 221483, 221600, 232408, 241133, 241134, 241135, 241136, 241137, 214292, 219538, 221467, 221468, 221470, 221475, 221479, 221480, 222651, 222684, 241138, 241139 | ||
| Bug Blocks: | |||
Dean Jackson
While unprefixing flexbox, I imported a bunch of official W3C tests. There are some failures. Some are minor reference differences, but others are significant differences. I have not checked if the test or the implementation is wrong. I did a random sample of failures and WebKit matches Blink, so I don't think these are showstoppers.
All found in css3/flexbox/csswg
css-box-justify-content.html
css-flexbox-img-expand-evenly.html
css-flexbox-row.html
css-flexbox-test1.html
flex-align-items-center.html
flex-flexitem-percentage-prescation.html
flex-items-flexibility.html
flex-lines/multi-line-wrap-reverse-column-reverse.html
flex-lines/multi-line-wrap-with-column-reverse.html
flex-margin-no-collapse.html
flexbox-flex-wrap-flexing.html
flexbox_flex-0-0-0.html
flexbox_flex-0-1-0.html
flexbox_flex-0-N-0.html
flexbox_flex-natural-mixed-basis-auto.html
flexbox_generated-container.html
flexbox_justifycontent-center-overflow.html
flexbox_min-height-auto.html
flexbox_min-width-auto.html
flexbox_stf-table-singleline.html
flexbox_visibility-collapse-line-wrapping.html
flexbox_visibility-collapse.html
flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom.html
order/order-with-column-reverse.html
ttwf-reftest-flex-direction-row-reverse.html
ttwf-reftest-flex-inline.html
ttwf-reftest-flex-order.html
ttwf-reftest-flex-wrap-reverse.html
ttwf-reftest-flex-wrap.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/18311645>
Marcos ChavarrÃa Teijeiro (irc: chavaone)
css3/flexbox/csswg/flexbox_direction-row-reverse.html test is passing since r180652. This revision changes the test and updated the expected file.
Updating GTK Test Expectations on https://bugs.webkit.org/show_bug.cgi?id=142665
Michael Catanzaro
css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html is passing r227528.
Carlos Alberto Lopez Perez
The WPT tests https://wpt.live/css/css-flexbox/flexbox_stf-table-singleline.html and https://wpt.live/css/css-flexbox/flexbox_stf-table-singleline-2.html fail on WebKit
This tests are basically the same than LayoutTests/css3/flexbox/csswg/flexbox_stf-table-singleline.html
The failure on Safari its an unexpected blue/red background:
* Safari failure for css/css-flexbox/flexbox_stf-table-singleline.html: https://wpt.fyi/analyzer?screenshot=sha1%3A034d36646df057ddd5e8ff3ccd330431db7a0c65&screenshot=sha1%3A4693e37e925647c4bc3c064991bae5cbcec2b911
* Safari failure for css/css-flexbox/flexbox_stf-table-singleline-2.html: https://wpt.fyi/analyzer?screenshot=sha1%3A1585ef705a01ac8899c12877d8fb214a3d58a039&screenshot=sha1%3A4693e37e925647c4bc3c064991bae5cbcec2b911
This test lacks a "content" keyword so it's not documented what it exactly tests and the git log doesn't give you any interesting detail. So it's not obvious to me what it is exactly testing or why it fails on WebKit.
However, this test passes on Chrome and Firefox, WebKit its the only engine failing them.
Sergio Villar Senin
I'll start using this to track interoperability issues in our Flexbox implementation that can be tracked down to WPT tests.