Bug 136726

Summary: Support rubber-banding in sub-frames
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Beth Dakin
Reported 2014-09-10 16:41:43 PDT
We should support rubber-banding in sub-frames. rdar://problem/10011924
Attachments
Patch (10.13 KB, patch)
2014-09-10 17:03 PDT, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-09-10 17:03:06 PDT
Created attachment 237918 [details] Patch Though there are some small changes in 2 latching test results, I don't think that this patch changes any of the latching behaviors. That being said, it does seem like latching is a little broken on TOT right now with iframes. Specifically, if you start a momentum scroll gesture in an iframe then right now in TOT, if the gesture is strong enough, the main frame will start scrolling as a part of that same gesture once you reach the end of the subframe. That shouldn't happen. Again, not a regression with this patch, just something we should fix. But in other cases (it's not a momentum gesture, or the main frame isn't scrollable) you get the correct rubber-banding behavior.
Beth Dakin
Comment 2 2014-09-10 17:22:14 PDT
I filed https://bugs.webkit.org/show_bug.cgi?id=136729 for the existing latching bug.
Beth Dakin
Comment 3 2014-09-11 11:48:48 PDT
Thanks Tim! http://trac.webkit.org/changeset/173523
Note You need to log in before you can comment on or make changes to this bug.