Bug 136710

Summary: Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Oliver Hunt 2014-09-10 12:47:00 PDT 
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Comment 1 Oliver Hunt 2014-09-10 12:47:29 PDT 
Created attachment 237898 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-10 12:48:55 PDT 
Attachment 237898 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:66:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:67:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-09-10 13:27:09 PDT 
Comment on attachment 237898 [details]
Patch

rs=me
Comment 4 Oliver Hunt 2014-09-10 14:52:19 PDT 
Committed r173490: <http://trac.webkit.org/changeset/173490>