Bug 136704

Summary: [Curl] Optimization; avoid reallocating string many times.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2014-09-10 06:47:07 PDT 
Adding individual characters to a string is inefficient, the string will be reallocated each time.
Comment 1 peavo 2014-09-10 06:51:25 PDT 
Created attachment 237889 [details]
Patch
Comment 2 Alex Christensen 2014-09-10 08:29:23 PDT 
Comment on attachment 237889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42
> +    token = WTF::move(strToken);

Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move?
Comment 3 peavo 2014-09-10 09:09:08 PDT 
Created attachment 237893 [details]
Patch
Comment 4 peavo 2014-09-10 09:09:40 PDT 
(In reply to comment #2)
> (From update of attachment 237889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review
> 
> > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42
> > +    token = WTF::move(strToken);
> 
> Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move?

Yes, thank you, updated patch :)
Comment 5 WebKit Commit Bot 2014-09-10 11:10:54 PDT 
Comment on attachment 237893 [details]
Patch

Clearing flags on attachment: 237893

Committed r173474: <http://trac.webkit.org/changeset/173474>
Comment 6 WebKit Commit Bot 2014-09-10 11:10:57 PDT 
All reviewed patches have been landed.  Closing bug.