Bug 136691

Summary:

Web Inspector: Eliminate typeof "undefined" checks

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-09-09 18:29:28 PDT

A long time ago, `undefined` could be re-assigned. Which could cause craziness comparing to undefined. That has not been the case for a while.

We can just convert:

    typeof foo === "undefined"

To:

    foo === undefined

Comment 1 Joseph Pecoraro 2014-09-09 18:30:10 PDT

Created attachment 237876 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2014-09-10 15:41:29 PDT

Comment on attachment 237876 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237876

Committed r173494: <http://trac.webkit.org/changeset/173494>

Comment 3 WebKit Commit Bot 2014-09-10 15:41:31 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Brian Burg 2014-09-10 16:10:26 PDT

Comment on attachment 237876 [details]
[PATCH] Proposed Fix

Was this supposed to include a change to .eslintrc?