Bug 136682 – Web Inspector: Fix ESLint consistent-return warnings

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

This warning warns about inconsistent use of "return x" and "return" within a function.

This fixes all but CodeMirrorCompletionController.js warning which have key handlers that either bail or return CodeMirror.Pass.

[Joseph Pecoraro]

Created attachment 237861 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 237863 [details]
[PATCH] Proposed Fix

Better fix, includes the change to the eslintrc file.

[Timothy Hatcher]

Comment on attachment 237863 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237863&action=review

> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:-389
>          console.assert(!this._waitingForMainFrameResourceTreePayload);
> -        if (this._waitingForMainFrameResourceTreePayload)
> -            return;

Why isn't the early return needed still? It would be bad to continue here.

[Joseph Pecoraro]

Comment on attachment 237863 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237863&action=review

>> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:-389
>> -            return;
> 
> Why isn't the early return needed still? It would be bad to continue here.

Checking all the callers, this should never be reached if this._waitingForMainFrameResourceTreePayload. So rather then return null which could throw an exception earlier on, I just left the assert.

[WebKit Commit Bot]

Comment on attachment 237863 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237863

Committed r173477: <http://trac.webkit.org/changeset/173477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.