Bug 136660

Summary:

Web Inspector: Fix ESLint no-undef warnings

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-09-08 20:21:29 PDT

ESLint emits a lot of no-undef warnings because we don't list all of our global utility functions (which we should probably namespace).

However these looked like some straight forward mistakes, and I'll follow up with a few other larger issues it catches.

Comment 1 Joseph Pecoraro 2014-09-08 20:22:11 PDT

Created attachment 237834 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2014-09-10 09:00:35 PDT

Comment on attachment 237834 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237834

Committed r173466: <http://trac.webkit.org/changeset/173466>

Comment 3 WebKit Commit Bot 2014-09-10 09:00:38 PDT

All reviewed patches have been landed.  Closing bug.