Bug 136659

Summary:

Web Inspector: Fix ESLint no-extra-bind warnings

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-09-08 20:19:00 PDT

There were two cases where we were doing an extra bind. One is a clear fix. The other looks like we might want to refactor and should be addressed separately.

Attachments
[PATCH] Proposed Fix (1.79 KB, patch) 2014-09-08 20:19 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (1.78 KB, patch) 2014-09-16 12:10 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-09-08 20:19:38 PDT

Created attachment 237833 [details] [PATCH] Proposed Fix

Jonathan Wells

Comment 2 2014-09-08 20:24:00 PDT

The one in TypeTokenView.js?

Joseph Pecoraro

Comment 3 2014-09-08 20:41:19 PDT

(In reply to comment #2) > The one in TypeTokenView.js? Yeah. In that case the timeout identifier should be set to null after it is cleared... I have to take a deeper look at it and address is individually.

Brian Burg

Comment 4 2014-09-10 15:13:43 PDT

Comment on attachment 237833 [details] [PATCH] Proposed Fix Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes? (Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused)

Joseph Pecoraro

Comment 5 2014-09-10 15:24:28 PDT

(In reply to comment #4) > (From update of attachment 237833 [details]) > Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes? > > (Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused) I don't think there is one. One could be written pretty quickly though.

Joseph Pecoraro

Comment 6 2014-09-16 12:10:15 PDT

Created attachment 238193 [details] [PATCH] Proposed Fix

Radar WebKit Bug Importer

Comment 7 2014-09-16 12:10:47 PDT

<rdar://problem/18354652>

WebKit Commit Bot

Comment 8 2014-09-16 12:54:22 PDT

Comment on attachment 238193 [details] [PATCH] Proposed Fix Clearing flags on attachment: 238193 Committed r173667: <http://trac.webkit.org/changeset/173667>

WebKit Commit Bot

Comment 9 2014-09-16 12:54:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.