Summary: | Web Inspector: Fix ESLint no-extra-bind warnings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-09-08 20:19:00 PDT
Created attachment 237833 [details]
[PATCH] Proposed Fix
The one in TypeTokenView.js? (In reply to comment #2) > The one in TypeTokenView.js? Yeah. In that case the timeout identifier should be set to null after it is cleared... I have to take a deeper look at it and address is individually. Comment on attachment 237833 [details]
[PATCH] Proposed Fix
Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes?
(Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused)
(In reply to comment #4) > (From update of attachment 237833 [details]) > Looks good. Is there a lint for the opposite problem, which is probably going to find more mistakes? > > (Incidentally, this looks like an easy place to convert to promises... once promises work when the debugger is paused) I don't think there is one. One could be written pretty quickly though. Created attachment 238193 [details]
[PATCH] Proposed Fix
Comment on attachment 238193 [details] [PATCH] Proposed Fix Clearing flags on attachment: 238193 Committed r173667: <http://trac.webkit.org/changeset/173667> All reviewed patches have been landed. Closing bug. |