Bug 136655

Summary: REGRESSION (r172129): Vine pages load as blank
Product: WebKit Reporter: Jeff Kelley <SlaunchaMan>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.9   
URL: https://vine.co/v/Oz7Vlz6EM1d
Attachments:
Description Flags
A screenshot of the bug.
none
the patch msaboff: review+

Description Jeff Kelley 2014-09-08 18:52:33 PDT 
It appears that the current WebKit nightly build (and several prior builds) can’t render pages on Vine. Screenshot of the included URL (https://vine.co/v/Oz7Vlz6EM1d) attached. I’m on 10.9.4 using WebKit in Safari at Version 7.0.6 (9537.78.2, r173400).
Comment 1 Jeff Kelley 2014-09-08 18:53:17 PDT 
Created attachment 237829 [details]
A screenshot of the bug.
Comment 2 Jeff Kelley 2014-09-08 18:55:04 PDT 
Oddly, if I open up Page Resources with ⌘⌥A, then refresh the page with that open, it works.
Comment 3 Alexey Proskuryakov 2014-09-09 12:42:14 PDT 
Regressed in <http://trac.webkit.org/changeset/172129>.
Comment 4 Alexey Proskuryakov 2014-09-09 12:42:34 PDT 
<rdar://problem/18281215>
Comment 5 Filip Pizlo 2014-09-11 12:34:01 PDT 
Created attachment 237979 [details]
the patch
Comment 6 Michael Saboff 2014-09-11 12:47:09 PDT 
Comment on attachment 237979 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> +                    if (sourceIndex - 1) {

I prefer if (sourceIndex > 1) for readability
Comment 7 Filip Pizlo 2014-09-11 12:53:18 PDT 
(In reply to comment #6)
> (From update of attachment 237979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> > +                    if (sourceIndex - 1) {
> 
> I prefer if (sourceIndex > 1) for readability

I agree.  Will change.
Comment 8 Filip Pizlo 2014-09-11 13:05:00 PDT 
Landed in http://trac.webkit.org/changeset/173534