Bug 136633

Summary: [WinCairo] Compile error.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue, darin, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2014-09-08 09:15:07 PDT 
Compiling AudioHardwareListener.cpp, I get the following compile error:

AudioHardwareListener.h(35) : error C2365 : 'Unknown' : redefinition; previous definition was 'enumerator' (..\html\HTMLElementsAllInOne.cpp) C:\WebKit\Source\WebCore\platform\network\HTTPParsers.h(84) : see declaration of 'Unknown'.
Comment 1 peavo 2014-09-08 09:18:24 PDT 
Created attachment 237791 [details]
Patch
Comment 2 peavo 2014-09-08 10:16:28 PDT 
Created attachment 237793 [details]
Patch
Comment 3 peavo 2014-09-08 10:17:47 PDT 
(In reply to comment #2)
> Created an attachment (id=237793) [details]
> Patch

Previous patch caused some new compile errors.
Comment 4 Darin Adler 2014-09-08 10:26:15 PDT 
Comment on attachment 237793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237793&action=review

> Source/WebCore/platform/audio/AudioHardwareListener.h:34
> +enum class AudioHardwareActivityType {

I’m amazed that this compiles without adding AudioHardwareActivityType:: prefixes in various places. But if it does, great!
Comment 5 WebKit Commit Bot 2014-09-08 11:54:21 PDT 
Comment on attachment 237793 [details]
Patch

Clearing flags on attachment: 237793

Committed r173391: <http://trac.webkit.org/changeset/173391>
Comment 6 WebKit Commit Bot 2014-09-08 11:54:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 peavo 2014-09-08 12:21:00 PDT 
(In reply to comment #4)
> (From update of attachment 237793 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237793&action=review
> 
> > Source/WebCore/platform/audio/AudioHardwareListener.h:34
> > +enum class AudioHardwareActivityType {
> 
> I’m amazed that this compiles without adding AudioHardwareActivityType:: prefixes in various places. But if it does, great!

Seems to build on all builders, thanks for reviewing :)