Bug 136630

Summary:

[CSS Grid Layout] RenderGrid methods should take RenderBox references

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

New Bugs

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dino, esprehn+autocc, glenn, jfernandez, koivisto, kondapallykalyan, rego

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	darin: review+

Description Sergio Villar Senin 2014-09-08 07:21:22 PDT

[CSS Grid Layout] RenderGrid methods should take RenderBox references

Comment 1 Sergio Villar Senin 2014-09-08 07:29:17 PDT

Created attachment 237784 [details]
Patch

Comment 2 Darin Adler 2014-09-08 08:02:37 PDT

Comment on attachment 237784 [details]
Patch

Separate thought: Can the type be more specific than RenderBox?

Comment 3 Sergio Villar Senin 2014-09-09 03:31:09 PDT

(In reply to comment #2)
> (From update of attachment 237784 [details])
> Separate thought: Can the type be more specific than RenderBox?

I don't think so,  if I am not wrong any RenderBox can be a child.

Comment 4 Sergio Villar Senin 2014-09-09 04:39:59 PDT

Committed r173427: <http://trac.webkit.org/changeset/173427>